Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/custom onDropHandler for viewportGrid #4641

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Feat/custom onDropHandler for viewportGrid #4641

merged 5 commits into from
Jan 29, 2025

Conversation

Jaseel-trenser
Copy link
Contributor

Context

  • An option has been implemented to allow custom onDropHandler in viewort grid. This enhancement enables users for handling of additional functionalities during the onDrop event to the viewport.
  • This PR has been incorporated by FlyWheel.io.

Changes & Results

  • Introduced a custom onDropHandler to handle additional functionalities during the onDrop to the viewpor

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18.20.3
  • Browser: Chrome

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/679a34f2d6f213091ffe321f
😎 Deploy Preview https://deploy-preview-4641--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 23fce1c
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6799cc3a1a465800086c3854

@sedghi
Copy link
Member

sedghi commented Jan 23, 2025

Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience

@Jaseel-trenser Jaseel-trenser force-pushed the feat/custom-onDropHandler-for-viewportGrid branch from 651d7f7 to 6196ac2 Compare January 24, 2025 05:53
@Jaseel-trenser
Copy link
Contributor Author

Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience

@sedghi I’ve rebased and updated the changes based on the new customization service.

sedghi
sedghi approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sedghi sedghi merged commit 054b262 into OHIF:master Jan 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sen-trenser sen-trenser sen-trenser left review comments

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaseel-trenser @sedghi @sen-trenser